Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TableView Issues #53

Closed
asikand-view opened this issue Jun 11, 2018 · 5 comments
Closed

TableView Issues #53

asikand-view opened this issue Jun 11, 2018 · 5 comments

Comments

@asikand-view
Copy link

asikand-view commented Jun 11, 2018

I have cards working as TableViewCell's and they are working fine apart from two major issues.

  1. When you dismiss the card, and it returns to its place in the TableView it is often misaligned or has adjusted its size strangely.

Notice the third cell
misaligned

  1. After opening and dismissing Cards in the TableView, eventually, the cards stop presenting the view controller content. Like this:

Working
screen shot 2018-06-11 at 11 51 21 am
Stops Presenting
screen shot 2018-06-11 at 11 52 10 am

@Varmoes
Copy link

Varmoes commented Jun 19, 2018

I've got the same two issues. On issue number 1, I found it's affected by scrolling (if you put your finger on a card and start scrolling, it seems to interpret it as being long pressed).

@asikand-view
Copy link
Author

I think the disappearing content has to do with the View becoming stale as part of a stack or there being some kind of a memory issue, I'm no pro but I think it could relate to #43

@asikand-view
Copy link
Author

asikand-view commented Jun 19, 2018

@Varmoes @PaoloCuscela
I've solved Issue Number 1 with this fix in Card.swift:

private func pushBackAnimated() {
    //UIView.animate(withDuration: 0.2, animations: { self.transform = CGAffineTransform(scaleX: 0.95, y: 0.95) })
}

@PaoloCuscela
Copy link
Owner

Fixed each of them. Good work 👍

@skeetyeet
Copy link

skeetyeet commented Sep 3, 2018

Hi I am still getting the 2nd issue. How was it solved in this case? Thanks in advance.

(After I open/close 5 different cards, the issue occurs)

Edit: Nevermind. Found that the detail controllers view alpha was staying at 0 for some reason.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants