-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix synced folder mounting on guests having Upstart #307
Conversation
machine.communicate.sudo( | ||
"/sbin/initctl emit --no-wait vagrant-mounted MOUNTPOINT=#{expanded_guest_path}") | ||
end | ||
emit_upstart_notification(machine, expanded_guest_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emit_upstart_notification
is available only in Vagrant 2.0+, so it will break the backward compatibility.
I'd recommend trying the old notation, as it was in virtualbox
provider:
machine.communicate.sudo <<-EOH.gsub(/^ {10}/, "")
if command -v /sbin/init && /sbin/init 2>/dev/null --version | grep upstart; then
/sbin/initctl emit --no-wait vagrant-mounted MOUNTPOINT=#{guest_path}
fi
EOH
hashicorp/vagrant@9f393fc#diff-97d643b35101562477f4b556a379415fL91
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done as you suggest.
test/unit/driver/pd_10_test.rb
Outdated
@@ -1,3 +1,4 @@ | |||
require 'rspec/collection_matchers' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering - why did you add this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this line this test file would not compile for me. There was issue with some operators that have apparently moved to collection_matches
submodule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed that line just to double check... Surprisingly, but now tests do not fail.
45f35c7
to
d06f19e
Compare
@dvolosnykh Thank you! I've rebased your branch to fix merge conflicts. Merging... |
Released in v1.7.7 |
Update dependencies to keep on par with current Vagrant state.