Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add TCP alternative to RakNet #76

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add TCP alternative to RakNet #76

wants to merge 8 commits into from

Conversation

TwistedAsylumMC
Copy link
Member

No description provided.

DaPigGuy
DaPigGuy reviewed Sep 17, 2022
View reviewed changes
server/server.go

playerCount atomic.Int64
}

// New creates a new Server with the provided name, group and address.
func New(name, address string) *Server {
// New creates a new Server with the provided name, group and address as well as if the connection should use the RakNet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// New creates a new Server with the provided name, group and address as well as if the connection should use the RakNet
// New creates a new Server with the provided name and address as well as if the connection should use the RakNet

@Endermanbugzjfc
Copy link
Contributor

What is the significance of this?

@TwistedAsylumMC
Copy link
Member Author

@Endermanbugzjfc improves performance on the proxy <-> server level, there's no point of using RakNet because it's just got a lot of useless bloat that does nothing but slow it down

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@DaPigGuy DaPigGuy DaPigGuy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TwistedAsylumMC @Endermanbugzjfc @DaPigGuy