Skip to content

Don't overwrite global.process #40

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
parshap opened this issue Feb 19, 2017 · 1 comment
Open

Don't overwrite global.process #40

parshap opened this issue Feb 19, 2017 · 1 comment

Comments

@parshap
Copy link

parshap commented Feb 19, 2017

TcpSocket.js#L11 overwrites the process global. This causes existing process.env values to be lost. I think this library should leave it to the end-user to shim the global process object (example). Regardless, I don't think it should clobber existing process.env values as it causes the rest of my program, which depend on the process.env values, to fail.
@olegdeezus
Copy link

Created PR #70

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parshap @olegdeezus