Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

JSON upload for batch and product accepts values for greyed out fields #1072

Closed
steinso2 opened this issue Dec 2, 2022 · 3 comments
Closed
Assignees
Labels
bug Something isn't working Enterprise Wallet Issues /Stories concerning upgrading the existing ePI platform - including ePI Enterprise wallet

Comments

@steinso2
Copy link

steinso2 commented Dec 2, 2022

  1. I created JSON and set flags to true, even they are grayed out and shouldn't be maintainable (because the functions are deactivated)
  2. result is: fields were accepted and changed, see result in UI
    image
@steinso2 steinso2 added bug Something isn't working Enterprise Wallet Issues /Stories concerning upgrading the existing ePI platform - including ePI Enterprise wallet labels Dec 2, 2022
@salboaie
Copy link
Member

salboaie commented Dec 5, 2022

@steinso2 is this an important fix for MVP1? it will require new validation code for something that should not happen by accident...

@steinso2
Copy link
Author

steinso2 commented Dec 5, 2022

Even if we only consider the field which is part of the scope of MVP1: "enable expired expiration date", it shouldn't be changeable using json.
We can control it procedural but it has to be clear to all, because I was surprised that it is changeable by json.

In functional requirement we stated;
Only fields used in MVP1 are allowed to be used in json file (procedural control in user manual).
If flags/fields in json has different value than defined in the rules for MVP1, it shall fail from processing and shown in “failed import logs” with the relevant error message

Lets see what the others think

@salboaie
Copy link
Member

salboaie commented Dec 7, 2022

@adiganga2002 add validation rules to stop anything that is not for MVP1

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working Enterprise Wallet Issues /Stories concerning upgrading the existing ePI platform - including ePI Enterprise wallet
Projects
None yet
Development

No branches or pull requests

3 participants