From 190eea0e7533ede6e8d16c91aa4f4719dc21bde8 Mon Sep 17 00:00:00 2001 From: Teodor Lupu Date: Wed, 5 Oct 2022 17:26:03 +0300 Subject: [PATCH 1/2] #933 fixed search arrows not working correctly --- lib/services/XMLDisplayService/XMLDisplayService.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/services/XMLDisplayService/XMLDisplayService.js b/lib/services/XMLDisplayService/XMLDisplayService.js index d282245..95decb9 100644 --- a/lib/services/XMLDisplayService/XMLDisplayService.js +++ b/lib/services/XMLDisplayService/XMLDisplayService.js @@ -259,7 +259,9 @@ class XmlDisplayService { let domNode = null; while (domNode = results.iterateNext()) { - resultNodes.push(domNode); + if (domNode.checkVisibility()) { + resultNodes.push(domNode); + } } for (let i = 0; i < resultNodes.length; i++) { let text = resultNodes[i].innerHTML; From 91314e2bcf1764fc9114cf88e53f495c0e0255e2 Mon Sep 17 00:00:00 2001 From: Teodor Lupu Date: Wed, 5 Oct 2022 17:30:52 +0300 Subject: [PATCH 2/2] #933 fixed search arrows not working correctly --- lib/services/XMLDisplayService/XMLDisplayService.js | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/services/XMLDisplayService/XMLDisplayService.js b/lib/services/XMLDisplayService/XMLDisplayService.js index 95decb9..ca69e6f 100644 --- a/lib/services/XMLDisplayService/XMLDisplayService.js +++ b/lib/services/XMLDisplayService/XMLDisplayService.js @@ -259,6 +259,7 @@ class XmlDisplayService { let domNode = null; while (domNode = results.iterateNext()) { + // checking if the element is rendered, such that it can be highlighted and scrolled into view if (domNode.checkVisibility()) { resultNodes.push(domNode); }