Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Resources/Assets: Clean up and load in a consistent way #81

Open
1 of 2 tasks
PhilippvK opened this issue Jan 20, 2021 · 1 comment
Open
1 of 2 tasks

Resources/Assets: Clean up and load in a consistent way #81

PhilippvK opened this issue Jan 20, 2021 · 1 comment

Comments

@PhilippvK
Copy link
Owner

PhilippvK commented Jan 20, 2021

Two things bother me a bit:

  • The TextManager is a total mess (decompiled) and loading the XML files in totally different ways than the other resources (f.e. using HTTP)
  • Most of the resources is actually unused or there are 3 versions of some Minigolf textures at different places. Let's reduce to an absolute minimum. Assets from other games can be still found via the legacy branch if required.
@PhilippvK PhilippvK changed the title Resources/Assets: Clean up and load in da consistent way Resources/Assets: Clean up and load in a consistent way Jan 26, 2021
@StenAL
Copy link

StenAL commented Jan 2, 2025

I did some clean up for TextManager resource loading in #125 (removing dead code to load .loc files, removing code duplication, simplifying the logic to load files) and further simplified the logic in d01af74 so a lot of the work is done.

There's still some more improvements to do here like removing the custom XML parsing logic and using Java standard library APIs instead.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants