-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add sign-comparison analysis functionality #330
Comments
As suggested during the last meeting, now a node is painted pink if it is different but not totally different, i.e., pink when only a subset of its children does not match. However, I am not sure about which colour to paint the node if its children are pink. For example, see H1.Mov1 of sign2 below. H1.Mov1 is currently in red because a node can only look at its direct children and check whether they are coloured or not. Painting red makes sense because it would mean no children are white. However, it also makes sense to paint H1.Mov1 in pink if we want to reserve red for completely different cases only. I'm uncertain which of the two colours would be most appropriate. |
@stannam Thanks! As I mentioned in the meeting, I'm actively thinking about this (indeed, that's what I'm doing right now, ha, so perfect timing) and will get back to you on it! :) |
@stannam Great point. I think that ideally, if things simply don't correspond between signs, then the sign that doesn't have a specification where the other sign does gets a blank line. So, you're totally right, the lines all end up yellow and expanding / collapsing, but if there's no specification on one side, it expands / collapses blank lines. I guess my first preference would be that the blank ones are truly blank: ...but if that's not feasible, I would be totally happy for them to also be yellow, where yellow just always means 'these things don't match and can't be fairly compared': To go back to the circle / zigzag case, it would look like this: |
@kchall @kvesik I think the sign alignment and the sign comparison are separable tasks, and it would be better for me to focus on the comparison side. Also, expecting other modules (i.e., other than Movement) are more tricky to compare, I think the assignment might be beyond my capabilities. Sorry for the delay! |
Thanks, Stanley! @kchall would you like me to separate out the module alignment task and make that my next focus? |
Allow a user to directly compare two signs for similarity, at varying levels of granularity. E.g.:
^ The user starts by seeing the top-level coding for each sign, colour coded as to whether it's a match or not. They can then drill down into the various areas to see which specific elements match or don't match:
The details about how elements are lined up with each other when they are not analogous will need to be worked out!
The text was updated successfully, but these errors were encountered: