Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

A lot of extra empty space in all the Action/State boxes in the Non Manual module. #346

Open
kvesik opened this issue Jul 5, 2024 · 4 comments
Labels
deferred may be addressed in the future. (low priority)

Comments

@kvesik
Copy link
Collaborator

kvesik commented Jul 5, 2024

There's a lot of extra empty space in all the Action/State boxes in the Non Manual module (true on both Kathleen's mac and Kaili's PC).

extra_space_in_NM.mov
@kvesik
Copy link
Collaborator Author

kvesik commented Jul 5, 2024

@kchall this was true on my PC as well, so I deleted your original comment in issue #27 and moved it to this new issue instead.

@stannam
Copy link
Member

stannam commented Jul 23, 2024

As discussed on 2024-07-18, I'm closing this issue. The spacing issue does not interfere with the core functionality, so we decided to leave it for now. However, progress has been made in branch 346 so someone may take it from there.

The main reason for this issue is that the outermost frame cannot be updated when changing the tabs. So, I wanted to ensure a large space from initialization. The space would be just to fit everything in a complex tab, e.g., Mouth > Tongue, but this inevitably results in too much space for a simple tab like Shoulder.

The solution I tried in branch 346 involves making parts scrollable so that all widgets in a complex tab can fit inside a smaller space. Although this solves the extra space issue, complex tabs ended up being overcrowded, as demonstrated during the last meeting.

These are the options that were considered during the meeting:

  • convert complex options as dropdown boxes, which do not take up too much space.
  • to the subtabs widget, add a button that 'collapses' the supertab so that subtabs can use more space.

@stannam stannam closed this as completed Jul 23, 2024
@stannam stannam added (low priority) deferred may be addressed in the future. labels Jul 23, 2024
@kchall
Copy link
Member

kchall commented Jul 24, 2024

Thanks, Stanley, this is great -- I think your explanation and labels are clear, but I'm going to re-open it so that we do actually have it on our future radars for working on at some point!

@kchall kchall reopened this Jul 24, 2024
@stannam stannam removed their assignment Jul 25, 2024
@stannam
Copy link
Member

stannam commented Sep 17, 2024

Maybe a simple solution is to add a buffer widget for space at the bottom?? The outermost frame would not need to be updated, but the bottom widget can take care of the excessive space. In short, extra space will be less of a problem if it is at the bottom??

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
deferred may be addressed in the future. (low priority)
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants