Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Child with named attribute fails to select #63

Closed
g105b opened this issue Aug 30, 2020 · 1 comment · Fixed by #168
Closed

Child with named attribute fails to select #63

g105b opened this issue Aug 30, 2020 · 1 comment · Fixed by #168
Labels
bug Something isn't working

Comments

@g105b
Copy link
Member

g105b commented Aug 30, 2020

form [name] should select all elements with a name attribute that are a child of a form. The selection breaks:

TypeError : Argument 1 passed to Gt\Dom\HTMLCollection::__construct() must be an instance of DOMNodeList, bool given, called in /home/g105b/Code/PhpGt/DomTemplate/vendor/phpgt/dom/src/ParentNode.php on line 72
@g105b g105b added the bug Something isn't working label Aug 30, 2020
@g105b
Copy link
Member Author

g105b commented Jan 30, 2022

Following on from this, the following selector fails to parse:

#containerId [name='something']

Same issue.

@tfedor tfedor mentioned this issue Jun 5, 2022
Merged
@g105b g105b closed this as completed in #168 Jun 8, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve detection of element in query tfedor/CssXPath
1 participant
@g105b