Fix orientation calculation in cost function and frame tests #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some issues that were filed recently, we discovered that the rotation cost was the biggest computational bottleneck.
Then, after talking to @stephanie-eng we realized the best path is to look at what
bio_ik
did -- specifically, they use the following KDL function whose implementation is here, which negates the quaternion dot product if it's less than zero because of "short vs. long path" of calculating an angle.Anyway, this sped up my results significantly when testing locally!