Fix Eigen::Affine3d for Melodic (using Eigen::Isometry3d) #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davetcoleman
force-pushed
the
melodic-isometry
branch
from
a938b03 to
3233fb9
Compare
10 tasks
rhaschke
approved these changes
Oct 24, 2018
|
@davetcoleman Can you merge (and release) this please as a pre-requisite of moveit/moveit#1096? This should not harm downstream packages as a conversion from Isometry to Affine is always possible. |
|
Done, but I doubt they'll let this in for this sync: ros/rosdistro#19532 |
|
Thanks. It's not necessary to have this released or synced right now. But this is a prerequisite for the remaining PRs. |
|
This is now breaking moveit_visual_tools on the build farm: |
|
Yes, of course. Before I will continue with the release process, I'm waiting for feedback on moveit/moveit#1225 (comment). |
12 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See moveit/moveit#1096
Must be merged at the same time as moveit's
@rhaschke