Skip to content

[BUG] Notion Database Page Does Not Support End Dates #14451

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
nickjanesdotcom opened this issue Oct 28, 2024 · 1 comment · Fixed by #14556
Closed

[BUG] Notion Database Page Does Not Support End Dates #14451

nickjanesdotcom opened this issue Oct 28, 2024 · 1 comment · Fixed by #14556
Assignees
Labels
bug Something isn't working triaged For maintainers: This issue has been triaged by a Pipedream employee

Comments

@nickjanesdotcom
Copy link

Describe the bug
When creating a database item in Notion it only allows us to select one date which is the start date and we should be able to select start date and end date.

To Reproduce
Steps to reproduce the behavior:

  1. Create a Workflow that Creates Page from Database that has a single Date property
  2. Try to Add Start Date and End Date to the Date Property

Expected behavior
Notion Date Property

{
  "scheduled date": {
    "date": {
      "start": "2022-01-01T00:00:00Z",
      "end": "2022-01-02T00:00:00Z"
    }
  }
}

Current:

  date: {
    type: "string",
    example: "2022-05-15T18:47:00.000Z",
    options: () => undefined,
    convertToNotion: (property) => ({
      date: {
        start: property.value,
      },
    }),
  }

Future:

date: {
  type: "object",
  example: {
    start: "2022-01-01T00:00:00Z",
    end: "2022-01-02T01:00:00Z",
  },
  options: () => undefined,
  convertToNotion: (property) => ({
    date: {
      start: property.value.start,
      end: property.value.end,
    },
  }),
}

Screenshots
If applicable, add screenshots to help explain your problem. Note that the screenshots will be displayed publicly.

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
I am not 100% sure on dependencies and what the process is but happy to work on the update.

@nickjanesdotcom nickjanesdotcom added the bug Something isn't working label Oct 28, 2024
@vunguyenhung vunguyenhung added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Nov 5, 2024
@michelle0927 michelle0927 self-assigned this Nov 5, 2024
@michelle0927 michelle0927 moved this from Prioritized to Doing in Component (Source and Action) Backlog Nov 5, 2024
@michelle0927 michelle0927 moved this from Doing to Ready for PR Review in Component (Source and Action) Backlog Nov 5, 2024
@lcaresia lcaresia moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Nov 7, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to Ready for Release in Component (Source and Action) Backlog Nov 8, 2024
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/BUG-Notion-Database-Page-Does-Not-Support-End-Dates-137bf548bb5e81beb509f85fafa8f57d

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working triaged For maintainers: This issue has been triaged by a Pipedream employee
Projects
Development

Successfully merging a pull request may close this issue.

3 participants