Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

boost::in_place can be replaced by emplace methods #2290

Closed
nvmkuruc opened this issue Feb 17, 2023 · 2 comments
Closed

boost::in_place can be replaced by emplace methods #2290

nvmkuruc opened this issue Feb 17, 2023 · 2 comments

Comments

@nvmkuruc
Copy link
Collaborator

Description of Issue

TfType and UsdStage use boost::in_place to initialize boost::optional instances. The STL has introduced emplace as the standard way to do in_place initialization. As recent versions of boost::optional support emplace, boost::in_place usage can be removed. Doing so will make it easier to swap out boost::optional for std::optional in the future and removes another boost dependency.

Steps to Reproduce

N/A

System Information (OS, Hardware)

N/A

Package Versions

N/A

Build Flags

N/A

@nvmkuruc
Copy link
Collaborator Author

I have a fix.

@sunyab
Copy link
Contributor

sunyab commented Feb 17, 2023

Filed as internal issue #USD-8027

@nvmkuruc nvmkuruc closed this as completed Mar 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants