"Vector iterators incompatible" in Sdf copyUtils

[seando-adsk]

Description of Issue

This line of code contains an operator== comparing two iterators that can come from different containers.

According to the standard comparing iterators from different contains is undefined. Once such example is here.

In the code finalIt could be from either the src or dst. When it's from the dst, this will trigger the following exception on Windows if you compile with STL iterator debugging:
_STL_VERIFY(this->_Getcont() == _Right._Getcont(), "vector iterators incompatible");

It should be a simple enough fix, but I wanted to log an issue to get your opinion on it and to see if there are other places that would need to be fixed.

Steps to Reproduce

1. Compile on Windows with iterator debugging enabled.
2. Invoke the SdfCopySpec function.

System Information (OS, Hardware)

Windows 10

Build Flags

_ITERATOR_DEBUG_LEVEL > 0

[jilliene]

Filed as internal issue #USD-5940

[sunyab]

@seando-adsk Thanks for filing this! We have a fix that should be pushed out to the dev branch soon.