gcc: disable placement-new warnings for boost<1.62 #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 8, 2020 16:04
This is an alternative solution to the same problem addressed: Locally disable placement-new warnings in later versions of gcc. 898b8c1 After discussion (PixarAnimationStudios#1074), we decided that the best solution would be to globally disable this for the affected combo of gcc + boost versions, since newer versions of boost are not affected.
…cc." This reverts commit 898b8c1.
|
Filed as internal issue #USD-5793 |
|
Looks great @elrond79 -- thanks very much! |
pixar-oss
added a commit
that referenced
this pull request
Feb 1, 2020
…_fix gcc: disable placement-new warnings for boost<1.62 (Internal change: 2035175)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This is an alternative solution to the same problem addressed by:
Locally disable placement-new warnings in later versions of gcc.
898b8c1
After discussion (#1074), we decided that the best solution would be to globally disable
this for the affected combo of gcc + boost versions, since newer
versions of boost are not affected.
Fixes Issue(s)