Attempt to fix a crash on Hydra update when a prototype primitive is removed #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…removed (deleted or deactivated) in the same update cycle where an inheritable primvar is added or changed to an ancestor of the prototype that used to exist.
|
Filed as internal issue #USD-6523 |
|
This PR was merged in commit 85e9400 and released in 21.05. Closing, thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix a crash on Hydra update when a prototype primitive is removed
(deleted or deactivated) in the same update cycle where an inheritable primvar
is added or changed to an ancestor of the prototype that used to exist.
Description of Change(s)
In UsdImagingPointInstancerAdapter::_GetProtoUsdPrim, test that prim is valid before calling prim.IsPrototype().
In UsdImagingPointInstancerAdapter::ProcessPropertyChange, if the prototype UsdPrim is invalid, set the dirty bits to "clean".
Fixes Issue(s)