APPLE: Fix CPU culling in PipelineDrawBatch #1956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
When using
HdSt_PipelineDrawBatch
, the logic inHdSt_RenderPass
was not checking that it had GPU culling disabled and therefore the CPU frustum culling was not being used.We now check the flag for both
HdSt_IndirectDrawBatch
andHdSt_PipelineDrawBatch
depending on what is enabled.Fixes Issue(s)
HD_FREEZE_CULL_FRUSTUM
debug option in usdView. Trucking the camera back should show that only the primitives within the frozen frustum are visible.