Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

APPLE: Fix CPU culling in PipelineDrawBatch #1956

Merged

Conversation

creijon
Copy link
Contributor

@creijon creijon commented Jul 19, 2022

Description of Change(s)

When using HdSt_PipelineDrawBatch, the logic in HdSt_RenderPass was not checking that it had GPU culling disabled and therefore the CPU frustum culling was not being used.

We now check the flag for both HdSt_IndirectDrawBatch and HdSt_PipelineDrawBatch depending on what is enabled.

Fixes Issue(s)

  • There was no frustum culling on the HdSt_PipelineDrawBatch, since the GPU culling isn't implemented yet. CPU culling was not being enabled in its place.
  • Tested by loading KitchenSet, moving camera into the scene and then using the HD_FREEZE_CULL_FRUSTUM debug option in usdView. Trucking the camera back should show that only the primitives within the frozen frustum are visible.
  • I have submitted a signed Contributor License Agreement

@sunyab
Copy link
Contributor

sunyab commented Jul 20, 2022

Filed as internal issue #USD-7503

@creijon creijon changed the title Fix CPU culling in PipelineDrawBatch [APPLE] Fix CPU culling in PipelineDrawBatch Jul 22, 2022
@creijon creijon changed the title [APPLE] Fix CPU culling in PipelineDrawBatch APPLE: Fix CPU culling in PipelineDrawBatch Jul 22, 2022
@creijon creijon force-pushed the jon/dev/pipelinedrawbatch_cull branch from fff4a87 to 4de0684 Compare August 2, 2022 04:35
@creijon creijon force-pushed the jon/dev/pipelinedrawbatch_cull branch from 4de0684 to 1f36851 Compare August 16, 2022 05:21
@pixar-oss pixar-oss merged commit f3fb4db into PixarAnimationStudios:dev Sep 1, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants