[usdShade] GetPrimvarNamesMetadataString - only append non-empty string #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on some compilers / architectures, if you do:
metadata["primvars] = GetPrimvarNamesMetadataString(...)
...this results in a default / empty string being inserted into
metadata["primvars"] BEFORE GetPrimvarNamesMetadataString is called.
Therefore, we only insert existing non-empty strings into the list that
GetPrimvarNamesMetadataString builds. (And it's a good check in general
anyway.)
This fixes a test failure in testUsdShadeShaderDef on linux aarch64
using gcc 7.5.
This was referenced Dec 12, 2022
|
Filed as internal issue #USD-7830 |
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
on some compilers / architectures, if you do:
...this results in a default / empty string being inserted into metadata["primvars"] BEFORE GetPrimvarNamesMetadataString is called. Therefore, we only insert existing non-empty strings into the list that GetPrimvarNamesMetadataString builds. (And it's a good check in general anyway.)
For more aarch64 related fixes, also see:
Fixes Issue(s)
failure of testUsdShadeShaderDef on linux aarch64 using gcc 7.5.
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement