Expose velocities attribute to render delegates #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
through Hydra as a primvar. Use the DirtyPoints dirty bit to track changes since the velocities attribue must be sampled at the same frequency as the points attribute.
In HdChangeTracker::IsPrimvarDirty, check the points dirty flag when asking if the velocities primvar is dirty. Add comments explaining the way velocities data is published.
|
Filed as internal issue #USD-5210 |
pixar-oss
added a commit
that referenced
this pull request
May 16, 2019
Expose velocities attribute to render delegates (Internal change: 1960490)
AdamFelt
pushed a commit
to autodesk-forks/USD
that referenced
this pull request
Apr 16, 2024
…lve/adsk/internal-only/feature/pipeline_adsk Update pipeline in adsk/dev
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a greatly simplified replacement for PR #743.
After discussions with the USD team, it was decided that velocities does not need its own dirty bit or dedicated change tracker or value cache functions. Instead, use the pointsDirty bit, and publish it as a regular primvar. Using the pointsDirty bit is reasonable because the velocities attribute, according to USD standards, should be published at the same time samples where the points attribute is published.