Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix usage of MAYA_LOCATION when building on osx #878

Merged

Conversation

pmolodo
Copy link
Contributor

@pmolodo pmolodo commented Jun 18, 2019

Description of Change(s)

Formerly, FindMaya.cmake assumed that MAYA_LOCATION on osx was set to
the top level installation dir, ie:

/Applications/Autodesk/maya2018

However, official Autodesk sources indicate that MAYA_LOCATION should
include Maya.app/Contents, ie:

/Applications/Autodesk/maya2018/Maya.app/Contents

For backward compatibility (and maximum convenience), FindMaya.cmake
still supports pointing at the top-level installation dir, but pointing
inside of Maya.app/Contents is now checked first.

Formerly, if MAYA_LOCATION was set to:

/Applications/Autodesk/maya2018/Maya.app/Contents

...but a maya 2019 install existed, at:

/Applications/Autodesk/maya2019

...then MAYA_BASE_DIR would end up pointing at the 2019 install, but
MAYA_LOCATION would stay pointing at 2018. This would result in some
things pointing at 2018, and some pointing at 2019, which obviously
created build problems.

For reference on the Autodesk's standard usage of MAYA_LOCATION on osx,
see:

Maya.app/Contents/Resources/mayald in the base install:

# NOTE: MAYA_LOCATION on the Mac OS X includes the path to the
# Maya.app/Contents directory.

/devkit/applications/Makefile in the devkit:
# NOTE: MAYA_LOCATION on Mac OS X points to Maya.app/Contents

You can also check the value that Maya itself sets MAYA_LOCATION to
from within maya when you launch the Maya.app by double clicking it.

Fixes Issue(s)

  • Build problems on MacOS when having MAYA_LOCATION include Maya.app/Contents (the "standard" usage of MAYA_LOCATION, according to Autodesk)

Formerly, FindMaya.cmake assumed that MAYA_LOCATION on osx was set to
the top level installation dir, ie:

    /Applications/Autodesk/maya2018

However, official Autodesk sources indicate that MAYA_LOCATION should
include Maya.app/Contents, ie:

    /Applications/Autodesk/maya2018/Maya.app/Contents

For backward compatibility (and maximum convenience), FindMaya.cmake
still supports pointing at the top-level installation dir, but pointing
inside of Maya.app/Contents is now checked first.

Formerly, if MAYA_LOCATION was set to:

    /Applications/Autodesk/maya2018/Maya.app/Contents

...but a maya 2019 install existed, at:

    /Applications/Autodesk/maya2019

...then MAYA_BASE_DIR would end up pointing at the 2019 install, but
MAYA_LOCATION would stay pointing at 2018.  This would result in some
things pointing at 2018, and some pointing at 2019, which obviously
created build problems.

For reference on the Autodesk's standard usage of MAYA_LOCATION on osx,
see:

Maya.app/Contents/Resources/mayald in the base install:

    # NOTE: MAYA_LOCATION on the Mac OS X includes the path to the
    # Maya.app/Contents directory.

/devkit/applications/Makefile in the devkit:
    # NOTE: MAYA_LOCATION on Mac OS X points to Maya.app/Contents

You can also check the value that Maya itself sets MAYA_LOCATION to
from within maya when you launch the Maya.app by double clicking it.
@pmolodo pmolodo force-pushed the pr/osx_MAYA_LOCATION_fix branch from 5805f74 to e671435 Compare June 18, 2019 17:14
@jilliene
Copy link

Filed as internal issue #USD-5381

@c64kernal
Copy link
Contributor

Thanks very much @elrond79 -- looks good!

@pixar-oss pixar-oss merged commit e671435 into PixarAnimationStudios:dev Jun 25, 2019
pixar-oss added a commit that referenced this pull request Jun 25, 2019
fix usage of MAYA_LOCATION when building on osx

(Internal change: 1981779)
AdamFelt pushed a commit to autodesk-forks/USD that referenced this pull request Apr 16, 2024
(OGSMOD-4660) Apply FT_Cache to improve text loading performance.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants