Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SetObserverTarget function missing #5

Open
Dim1xs opened this issue Jun 2, 2024 · 11 comments
Open

SetObserverTarget function missing #5

Dim1xs opened this issue Jun 2, 2024 · 11 comments

Comments

@Dim1xs
Copy link

Dim1xs commented Jun 2, 2024

Lua has everything for enabling Observer mode for player, but it dont has a function SetObserverTarget. That's kinda bad.

@GuestSneezeOSDev
Copy link
Contributor

@Dim1xs is this still an issue?

@Dim1xs
Copy link
Author

Dim1xs commented Sep 13, 2024

@GuestSneezeOSDev of course

@andrewmcwatters
Copy link
Member

@Dim1xs @GuestSneezeOSDev That's odd that we never implemented this. Looks like it's from the client-side CBasePlayer class?

@GuestSneezeOSDev
Copy link
Contributor

@Dim1xs Have you edited the source code in any way?

@Dim1xs
Copy link
Author

Dim1xs commented Sep 17, 2024

@andrewmcwatters I think you could, i found that function in player.h and in c_baseplayer.h, and i found also that SetBodygroup for Server-side of Lua CBaseAnimating is missing too.

@Dim1xs
Copy link
Author

Dim1xs commented Sep 17, 2024

@GuestSneezeOSDev nope, current source code doesn't compiles for me.

@GuestSneezeOSDev
Copy link
Contributor

@andrewmcwatters I recommend merging #7

@andrewmcwatters
Copy link
Member

@GuestSneezeOSDev I'd like to, too, but there's a number of minutiae that need to be addressed. It's on my backlog. That codebase evolved from 2006 -> 2007 -> 2013, so there's some large scale manual diff review that needs to go on.

Luckily, we mostly wrapped our diffs around HL2SB #ifdefs to make these ports overtime easy to handle, but it's still a large chore. And we never really adopted VPC, having a single target we were allowed to publish to since we weren't licensees. We simply patched the built project files and pushed them up over the years.

@andrewmcwatters
Copy link
Member

@GuestSneezeOSDev In theory, you should be able to check out a fresh copy of 2013, literally drop hl2sb-src on top of it, and see what changes there are wrapped in HL2SB ifdefs.

@GuestSneezeOSDev
Copy link
Contributor

I could potentially port the 2006 version of HL2SB to the 2013 branch of the Source Engine

@andrewmcwatters
Copy link
Member

@GuestSneezeOSDev I don't think too much really changes between them. It's really the engine itself, iirc. I'm not sure how much of the newer engine features we expose to Lua between the engine branches.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants