Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(components): create SelectInput #110

Merged
merged 5 commits into from
Oct 11, 2024
Merged

feat(components): create SelectInput #110

merged 5 commits into from
Oct 11, 2024

Conversation

joshuagraber
Copy link
Collaborator

@joshuagraber joshuagraber commented Oct 11, 2024

InputSelect component

  • Accessible
  • Keyboard navigable
  • Meets Non-customizable combobox spec
  • Like other input components, it handles error and label UI via props / slots.

Background

  • Implement designs for search v2

Description

  • Adds InputSelect component

Acceptance Criteria

  1. Run app, navigate to /form-v2-demo, ensure the ice cream flavor select menu is both click and keyboard navigable, and that it interacts with the form component.
Screen.Recording.2024-10-10.at.9.31.37.PM.mov

@joshuagraber joshuagraber self-assigned this Oct 11, 2024
@joshuagraber joshuagraber changed the title feat: create SelectInput feat(components): create SelectInput Oct 11, 2024
@joshuagraber joshuagraber merged commit ad35c57 into beta Oct 11, 2024
5 checks passed
@joshuagraber joshuagraber deleted the feat/select-input branch October 11, 2024 01:33
Copy link

🎉 This PR is included in version 3.1.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jan 2, 2025

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant