Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Large number of associated agencies breaks pdap.io/data-sources/{id} display #245

Open
maxachis opened this issue Mar 1, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@maxachis
Copy link
Contributor

maxachis commented Mar 1, 2025

https://pdap.io/data-source/1484

Image

JSON data shows that it is providing agencies data for 18 agencies, all aggregated. So the problem in this case is that there is such high number of agencies being represented that it is breaking the display logic.

There are several possible solutions to this, not necessarily mutually exclusive:

  1. We make the view of agencies be scrollable or collapsible once they get past a certain amount (perhaps 3).
  2. We add some new components to the /data-sources/{id} endpoint to filter agencies displayed in some form or fashion.

Additionally, it appears to be interfering with the NEXT functionality in some fashion. To demonstrate, open the page for Maryland Case Explorer (https://pdap.io/data-source/1519) and click PREV until getting back to Stanford. Then click NEXT and you'll find you won't be able to get back to Maryland Case Explorer.

@maxachis maxachis changed the title Aggregated Federal sources break pdap.io/data-sources/{id} display Large number of associated agencies breaks pdap.io/data-sources/{id} display Mar 1, 2025
@maxachis maxachis added the bug Something isn't working label Mar 1, 2025
@josh-chamberlain
Copy link
Contributor

josh-chamberlain commented Mar 2, 2025

for display issues, I'm suggesting:

  1. make the view of agencies be scrollable or collapsible once they get past 3
  2. don't show duplicate jurisdictions; show one tile for each, maximum
  3. since we're presenting agencies and states in a tabular structure, don't show the commas; just add a little space between the columns when there's only one entry.

@josh-chamberlain josh-chamberlain transferred this issue from Police-Data-Accessibility-Project/data-sources-app Mar 2, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants