Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace windows with windows-sys #118

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Conversation

Jake-Shadle
Copy link
Contributor

@Jake-Shadle Jake-Shadle commented Apr 13, 2023

The windows crate is massive overkill for the features needed by this crate, so this PR replaces it with just windows-sys and adds the minimal COM bindings used by this crate. This also updates from 0.44 to 0.48, which is the current latest version of windows/-sys

  • Crate download: ~12MiB -> ~2.5MiB
  • Untarred source: ~171MiB -> ~30MiB
  • Build (debug): ~6.5s(1.0s codegen) -> ~1.1s
  • Build (release): ~7.5s(2.5s codegen) -> ~1.17s

@Jake-Shadle Jake-Shadle requested a review from PolyMeilex April 25, 2023 13:24
@PolyMeilex PolyMeilex merged commit 6168ea6 into PolyMeilex:master Apr 26, 2023
@PolyMeilex
Copy link
Owner

Thanks!

@repi repi mentioned this pull request Aug 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants