Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

Use bluebird promises to improve performance #25

Closed
Stateford opened this issue Apr 28, 2017 · 1 comment
Closed

Use bluebird promises to improve performance #25

Stateford opened this issue Apr 28, 2017 · 1 comment

Comments

@Stateford
Copy link
Contributor

Stateford commented Apr 28, 2017

Built in node.js Promises are 4x slower than blue bird, It's better to bring in the package bluebird and add the line js const Promise = require('bluebird');

I can do a PR if you think it's warranted, but it's probably a good idea overall to do it.

@claviska claviska added this to the 1.0.0-alpha.3 milestone Apr 28, 2017
@claviska
Copy link
Member

claviska commented Apr 28, 2017

I was wondering about Bluebird, but wasn't aware it was actually faster. Good to know. It's already being used by some of Postleaf's deps, so I don't mind adding it to package.json. A PR would be great.

We could probably use Promise.mapSeries to address #5 as well.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants