Remove unused using statements and sort them (#931)

bergmeister · JamesWTruher · commit 614654665400 · 2018-03-20T15:24:30.000-07:00
* Remove and sort usings

* re-add accidentally removed using
diff --git a/Engine/Commands/GetScriptAnalyzerRuleCommand.cs b/Engine/Commands/GetScriptAnalyzerRuleCommand.cs
@@ -1,13 +1,13 @@
 ﻿// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+using Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic;
 using System;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Linq;
 using System.Management.Automation;
-using Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.Commands
 {
diff --git a/Engine/EditableText.cs b/Engine/EditableText.cs
@@ -1,15 +1,11 @@
 ﻿// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+using Microsoft.Windows.PowerShell.ScriptAnalyzer.Extensions;
 using System;
-using System.Collections;
-using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Globalization;
 using System.Linq;
-using System.Management.Automation.Language;
-using System.Text;
-using Microsoft.Windows.PowerShell.ScriptAnalyzer.Extensions;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer
 {
diff --git a/Engine/Generic/CorrectionExtent.cs b/Engine/Generic/CorrectionExtent.cs
@@ -1,13 +1,8 @@
 ﻿// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-using System;
 using System.Collections.Generic;
-using System.IO;
-using System.Linq;
 using System.Management.Automation.Language;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic
 {
diff --git a/Engine/Generic/DiagnosticRecord.cs b/Engine/Generic/DiagnosticRecord.cs
@@ -1,7 +1,6 @@
 ﻿// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-using System;
 using System.Collections.Generic;
 using System.Management.Automation.Language;
 
diff --git a/Engine/Generic/RuleSuppression.cs b/Engine/Generic/RuleSuppression.cs
@@ -2,11 +2,11 @@
 // Licensed under the MIT License.
 
 using System;
+using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
 using System.Management.Automation.Language;
-using System.Collections.Generic;
 using System.Text.RegularExpressions;
-using System.Globalization;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic
 {
diff --git a/Engine/Helper.cs b/Engine/Helper.cs
@@ -1,18 +1,16 @@
 ﻿// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+using Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic;
 using System;
+using System.Collections;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
+using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Management.Automation;
 using System.Management.Automation.Language;
-using System.Globalization;
-using Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic;
-using System.Management.Automation.Runspaces;
-using System.Collections;
-using System.Reflection;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer
 {
diff --git a/Engine/VariableAnalysis.cs b/Engine/VariableAnalysis.cs
@@ -3,9 +3,9 @@
 
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
 using System.Management.Automation.Language;
-using System.Globalization;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer
 {
diff --git a/Engine/VariableAnalysisBase.cs b/Engine/VariableAnalysisBase.cs
@@ -5,11 +5,11 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
+using System.Globalization;
 using System.Linq;
-using System.Reflection;
-using System.Management.Automation.Language;
 using System.Management.Automation;
-using System.Globalization;
+using System.Management.Automation.Language;
+using System.Reflection;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer
 {
diff --git a/Rules/AvoidNullOrEmptyHelpMessageAttribute.cs b/Rules/AvoidNullOrEmptyHelpMessageAttribute.cs
@@ -3,7 +3,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using System.Management.Automation.Language;
 using Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic;
 #if !CORECLR
diff --git a/Rules/AvoidReservedCharInCmdlet.cs b/Rules/AvoidReservedCharInCmdlet.cs
@@ -6,7 +6,6 @@
 using System.Linq;
 using System.Management.Automation.Language;
 using Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic;
-using Microsoft.Windows.PowerShell.ScriptAnalyzer;
 #if !CORECLR
 using System.ComponentModel.Composition;
 #endif
diff --git a/Rules/AvoidTrailingWhitespace.cs b/Rules/AvoidTrailingWhitespace.cs
@@ -8,7 +8,6 @@
 using System.ComponentModel.Composition;
 #endif
 using System.Globalization;
-using System.Linq;
 using System.Management.Automation.Language;
 using Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic;
 
diff --git a/Rules/AvoidUserNameAndPasswordParams.cs b/Rules/AvoidUserNameAndPasswordParams.cs
@@ -11,7 +11,6 @@
 using System.ComponentModel.Composition;
 #endif
 using System.Globalization;
-using System.Reflection;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
 {
diff --git a/Rules/AvoidUsingComputerNameHardcoded.cs b/Rules/AvoidUsingComputerNameHardcoded.cs
@@ -8,7 +8,6 @@
 using System.ComponentModel.Composition;
 #endif
 using System.Globalization;
-using System.Collections.Generic;
 using System.Linq;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
diff --git a/Rules/AvoidUsingPlainTextForPassword.cs b/Rules/AvoidUsingPlainTextForPassword.cs
@@ -9,8 +9,6 @@
 using System.ComponentModel.Composition;
 #endif
 using System.Globalization;
-using System.Reflection;
-using System.Text;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
 {
diff --git a/Rules/DscExamplesPresent.cs b/Rules/DscExamplesPresent.cs
@@ -21,7 +21,7 @@ namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
     ///     For class based resources it should be present at the same folder level as resource psm1 file. 
     /// Examples folder should contain sample configuration for given resource - file name should contain resource's name.
     /// </summary>
-    #if !CORECLR
+#if !CORECLR
 [Export(typeof(IDSCResourceRule))]
 #endif
     public class DscExamplesPresent : IDSCResourceRule
diff --git a/Rules/DscTestsPresent.cs b/Rules/DscTestsPresent.cs
@@ -21,7 +21,7 @@ namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
     ///     For class based resources it should be present at the same folder level as resource psm1 file. 
     /// Tests folder should contain test script for given resource - file name should contain resource's name.
     /// </summary>
-    #if !CORECLR
+#if !CORECLR
 [Export(typeof(IDSCResourceRule))]
 #endif
     public class DscTestsPresent : IDSCResourceRule
diff --git a/Rules/LoggerInfo.cs b/Rules/LoggerInfo.cs
@@ -1,11 +1,6 @@
 ﻿// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 using System.Diagnostics.CodeAnalysis;
 
 namespace Microsoft.Windows.Powershell.ScriptAnalyzer.Generic
diff --git a/Rules/MissingModuleManifestField.cs b/Rules/MissingModuleManifestField.cs
@@ -10,7 +10,6 @@
 using System.ComponentModel.Composition;
 #endif
 using System.Globalization;
-using System.Text;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
 {
diff --git a/Rules/PlaceOpenBrace.cs b/Rules/PlaceOpenBrace.cs
@@ -7,7 +7,6 @@
 using System.ComponentModel.Composition;
 #endif
 using System.Globalization;
-using System.Linq;
 using System.Management.Automation.Language;
 using System.Text;
 using Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic;
diff --git a/Rules/ProvideCommentHelp.cs b/Rules/ProvideCommentHelp.cs
@@ -10,9 +10,7 @@
 using System.ComponentModel.Composition;
 #endif
 using System.Globalization;
-using System.Management.Automation;
 using System.Text;
-using System.IO;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
 {
diff --git a/Rules/ReturnCorrectTypesForDSCFunctions.cs b/Rules/ReturnCorrectTypesForDSCFunctions.cs
@@ -16,7 +16,7 @@ namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
     /// <summary>
     /// ReturnCorrectTypeDSCFunctions: Check that DSC functions return the correct type.
     /// </summary>
-    #if !CORECLR
+#if !CORECLR
 [Export(typeof(IDSCResourceRule))]
 #endif
     public class ReturnCorrectTypesForDSCFunctions : IDSCResourceRule
diff --git a/Rules/UseCompatibleCmdlets.cs b/Rules/UseCompatibleCmdlets.cs
@@ -10,7 +10,6 @@
 using System.IO;
 using System.Linq;
 using System.Management.Automation.Language;
-using System.Reflection;
 using System.Text.RegularExpressions;
 using Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic;
 
@@ -21,7 +20,7 @@ namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
     /// <summary>
     /// A class to check if a script uses Cmdlets compatible with a given version and edition of PowerShell.
     /// </summary>
-    #if !CORECLR
+#if !CORECLR
     [Export(typeof(IScriptRule))]
 #endif
     public class UseCompatibleCmdlets : AstVisitor, IScriptRule
diff --git a/Rules/UseIdenticalParametersDSC.cs b/Rules/UseIdenticalParametersDSC.cs
@@ -17,7 +17,7 @@ namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
     /// UseIdenticalParametersDSC: Check that the Test-TargetResource and
     /// Set-TargetResource have identical parameters.
     /// </summary>
-    #if !CORECLR
+#if !CORECLR
 [Export(typeof(IDSCResourceRule))]
 #endif
     public class UseIdenticalParametersDSC : IDSCResourceRule
diff --git a/Rules/UseLiteralInitializerForHashtable.cs b/Rules/UseLiteralInitializerForHashtable.cs
@@ -9,7 +9,6 @@
 using System.ComponentModel.Composition;
 #endif
 using System.Globalization;
-using System.Linq;
 using System.Management.Automation.Language;
 using Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic;
 
@@ -18,7 +17,7 @@ namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
     /// <summary>
     /// A class to walk an AST to check if hashtable is not initialized using [hashtable]::new or new-object hashtable
     /// </summary>
-    #if !CORECLR
+#if !CORECLR
     [Export(typeof(IScriptRule))]
 #endif
     public class UseLiteralInitializerForHashtable : AstVisitor, IScriptRule
diff --git a/Rules/UsePSCredentialType.cs b/Rules/UsePSCredentialType.cs
@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 using System;
-using System.Reflection;
 using System.Linq;
 using System.Collections.Generic;
 using System.Management.Automation;
diff --git a/Rules/UseStandardDSCFunctionsInResource.cs b/Rules/UseStandardDSCFunctionsInResource.cs
@@ -16,7 +16,7 @@ namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
     /// <summary>
     /// UseStandardDSCFunctionsInResource: Checks if the DSC resource uses standard Get/Set/Test TargetResource functions.
     /// </summary>
-    #if !CORECLR
+#if !CORECLR
 [Export(typeof(IDSCResourceRule))]
 #endif
     public class UseStandardDSCFunctionsInResource : IDSCResourceRule
diff --git a/Rules/UseToExportFieldsInManifest.cs b/Rules/UseToExportFieldsInManifest.cs
@@ -10,7 +10,6 @@
 #if !CORECLR
 using System.ComponentModel.Composition;
 #endif
-using System.Text.RegularExpressions;
 using System.Diagnostics;
 using System.Text;
 using System.Globalization;
diff --git a/Rules/UseVerboseMessageInDSCResource.cs b/Rules/UseVerboseMessageInDSCResource.cs
@@ -10,14 +10,13 @@
 using System.ComponentModel.Composition;
 #endif
 using System.Globalization;
-using System.Management.Automation;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
 {
     /// <summary>
     /// UseVerboseMessageInDSCResource: Analyzes the ast to check that Write-Verbose is called for DSC Resources.
     /// </summary>
-    #if !CORECLR
+#if !CORECLR
 [Export(typeof(IDSCResourceRule))]
 #endif
     public class UseVerboseMessageInDSCResource : SkipNamedBlock, IDSCResourceRule
diff --git a/rules/UseSupportsShouldProcess.cs b/rules/UseSupportsShouldProcess.cs
@@ -3,7 +3,6 @@
 
 using System;
 using System.Linq;
-using System.Text;
 using System.Collections.Generic;
 #if !CORECLR
 using System.ComponentModel.Composition;

Original file line number	Diff line number	Diff line change
`@@ -3,9 +3,9 @@`
`3`	`3`
`4`	`4`	`using System;`
`5`	`5`	`using System.Collections.Generic;`
	`6`	`+using System.Globalization;`
`6`	`7`	`using System.Linq;`
`7`	`8`	`using System.Management.Automation.Language;`
`8`		`-using System.Globalization;`
`9`	`9`
`10`	`10`	`namespace Microsoft.Windows.PowerShell.ScriptAnalyzer`
`11`	`11`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@`
`11`	`11`	`using System.ComponentModel.Composition;`
`12`	`12`	`#endif`
`13`	`13`	`using System.Globalization;`
`14`		`-using System.Reflection;`
`15`	`14`
`16`	`15`	`namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules`
`17`	`16`	`{`
Original file line number	Diff line number	Diff line change
`@@ -9,8 +9,6 @@`
`9`	`9`	`using System.ComponentModel.Composition;`
`10`	`10`	`#endif`
`11`	`11`	`using System.Globalization;`
`12`		`-using System.Reflection;`
`13`		`-using System.Text;`
`14`	`12`
`15`	`13`	`namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules`
`16`	`14`	`{`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@`
`10`	`10`	`using System.ComponentModel.Composition;`
`11`	`11`	`#endif`
`12`	`12`	`using System.Globalization;`
`13`		`-using System.Text;`
`14`	`13`
`15`	`14`	`namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules`
`16`	`15`	`{`
Original file line number	Diff line number	Diff line change
`@@ -10,9 +10,7 @@`
`10`	`10`	`using System.ComponentModel.Composition;`
`11`	`11`	`#endif`
`12`	`12`	`using System.Globalization;`
`13`		`-using System.Management.Automation;`
`14`	`13`	`using System.Text;`
`15`		`-using System.IO;`
`16`	`14`
`17`	`15`	`namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules`
`18`	`16`	`{`