Tests fixes for AvoidPositionalParameters rule.

kalgiz · kalgiz · commit 8fae82ed49c1 · 2018-04-12T16:14:45.000-07:00
diff --git a/Tests/Rules/AvoidPositionalParameters.tests.ps1 b/Tests/Rules/AvoidPositionalParameters.tests.ps1
@@ -37,12 +37,10 @@ Describe "AvoidPositionalParameters" {
                     [Parameter(Position=2)]$B,
                     [Parameter(Position=3)]$C)
                 }
-                Foo "a" "b" "c"
-            }
+                Foo "a" "b" "c"}
             $warnings = Invoke-ScriptAnalyzer -ScriptDefinition "$sb"
-            $warnings.Count | Should -BeGreaterThan 0
-            $warnings.RuleName | Should -Contain $violationName
-            $warnings.Message | Should -Contain "Cmdlet 'Foo' has positional parameter. Please use named parameters instead of positional parameters when calling a command."
+            $warnings.Count | Should -Be 1
+            $warnings.RuleName | Should -BeExactly $violationName
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -37,12 +37,10 @@ Describe "AvoidPositionalParameters" {`
`37`	`37`	`[Parameter(Position=2)]$B,`
`38`	`38`	`[Parameter(Position=3)]$C)`
`39`	`39`	`}`
`40`		`- Foo "a" "b" "c"`
`41`		`- }`
	`40`	`+ Foo "a" "b" "c"}`
`42`	`41`	`$warnings = Invoke-ScriptAnalyzer -ScriptDefinition "$sb"`
`43`		`- $warnings.Count \| Should -BeGreaterThan 0`
`44`		`- $warnings.RuleName \| Should -Contain $violationName`
`45`		`- $warnings.Message \| Should -Contain "Cmdlet 'Foo' has positional parameter. Please use named parameters instead of positional parameters when calling a command."`
	`42`	`+ $warnings.Count \| Should -Be 1`
	`43`	`+ $warnings.RuleName \| Should -BeExactly $violationName`
`46`	`44`	`}`
`47`	`45`	`}`
`48`	`46`	`}`