Skip to content

Investigate/Fix test failure on PowerShell Core #944

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
bergmeister opened this issue Mar 23, 2018 · 1 comment
Open

Investigate/Fix test failure on PowerShell Core #944

bergmeister opened this issue Mar 23, 2018 · 1 comment

Comments

@bergmeister
Copy link
Collaborator

bergmeister commented Mar 23, 2018

  • The "suggests corrections for AliasesToExport with wildcard of UseManifestExportFields is currently set as pending when tests are being run using the coreclr.
    This tests needs to be looked into and possibly fixed.
    The test is here:
    It "suggests corrections for AliasesToExport with wildcard" -pending:($IsCoreClr) {
  • There are 9 test failures using PowerShell Core on Windows and Ubuntu but they do not fail in AppVeyor for some reason. Those tests were always failing, even when going back to an old commit like 9e37dd34e8564dc7470dda1e0d2596de37bcd679 in January. Therefore those failures are to be considered technical debt. Until we know why AppVeyor lets them pass and fix them afterwards, we have to more diligent with running tests locally or on VSTS using PowerShell Core to make sure that we do not introduce regression. The test failures are:
    pssa_corefailures1
    pssa_corefailures2
@bergmeister
Copy link
Collaborator Author

bergmeister commented Nov 8, 2018

I found the reason now: locally I have en-GB culture but the CommunityAnalyzer module that is used by tests provides only locale for en-us, this is probably a PSCore bug (changing the language folder to match my locale makes it work, which is not required in Windows PowerShell)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant