Skip to content

DefaultShellCommandOption has an unreasonably small size limit #2125

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
samhocevar opened this issue Aug 18, 2023 · 1 comment
Closed

DefaultShellCommandOption has an unreasonably small size limit #2125

samhocevar opened this issue Aug 18, 2023 · 1 comment
Assignees

Comments

@samhocevar
Copy link

samhocevar commented Aug 18, 2023

Summary of the new feature / enhancement

The DefaultShellCommandOption registry key has a size limit of 15 characters. This seems unreasonably small especially since DefaultShellArguments has a much larger limit and its contents are not used for a non-interactive shell, so a lot of what is in there has to be duplicated.

For instance, if I wanted to configure OpenSSH to use MSYS2 without creating a helper script, this is what my registry keys would look like:

DefaultShell                 C:\msys64\msys2_shell.cmd
DefaultShellArguments        -defterm -mingw64 -no-start -shell zsh
DefaultShellCommandOption    -defterm -mingw64 -no-start -shell zsh -c
DefaultShellEscapeArguments  0

Proposed technical implementation details (optional)

This PR increases the limit to the same value as DefaultShellArguments, which is currently PATH_MAX / 2 - 1.

@tgauth
Copy link
Collaborator

tgauth commented Oct 16, 2023

closing - available in 9.4 release

@tgauth tgauth closed this as completed Oct 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants