Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Roadmap] Improve Themes section #1321

Open
4 of 21 tasks
matks opened this issue Mar 17, 2022 · 2 comments
Open
4 of 21 tasks

[Roadmap] Improve Themes section #1321

matks opened this issue Mar 17, 2022 · 2 comments
Labels

Comments

@matks
Copy link
Contributor

matks commented Mar 17, 2022

Getting started

  • Guidelines and coding standards 🟠
  • Setting up your local environment 🟠
  • Required tools ➑️ generic, should go somewhere else
  • Theme organization βœ…
  • Theme.yml 🟠
  • Asset Management 🟠
    • Webpack 🟠

Reference

  • Theme Hooks 🟠
  • Javascript Events 🟠
  • Migrating from PrestaShop 1.6 ➑️ must become "Migrating from PrestaShop 1.7 to 8"
  • Overriding modules 🟠
  • Overriding selectors 🟠
  • RTL support 🟠
  • Template inheritance βœ…
    • Parent/child theme 🟠
  • Templates 🟠
  • Template hierarchy πŸ”΄
  • Theme translation βœ…
  • Theme-specific modules βœ…
  • Distribution ➑️ must be removed

Other

➑️= must move or must be removed
βœ… = quite complete (although can always be improved)
🟠 = can be improved
πŸ”΄ = does not exist

@matks
Copy link
Contributor Author

matks commented Mar 17, 2022

Some very good notes from @kpodemski :

Getting started

Setting up your local environment

  1. probably needs to show how to use stable release too, the link between this page and page about the branches/installation of PrestaShop
  2. show alternatives to Classic
  3. there's no theme.dist.yml

the entire process should be performed by the developer and updated accordingly

Required tools

This section is valid for the entire project in many places. We probably need to move it to a better place but leave it here with the URLs.

Theme.yml

Theme configuration?

Lack of info that PrestaShop is keeping .yml files in the cache "config/themes/theme_name". Sometimes it might be confusing when you change the theme.yml, reset it, and nothing happens.

For the new theme we will need, a dedicated flag.

Asset management

Confusing structure. There's the part about adding assets through modules. Maybe it should be moved and only linked from here. Webpack page is outdated.

@matks
Copy link
Contributor Author

matks commented Mar 17, 2022

Some very good notes from @kpodemski :

Reference

Theme Hooks

Examples with registering our hooks are invalid.
{hook} has optional parameters available.

Javascript Events

List of events to be checked

Overriding modules

We can also override email templates. There's no info about that.

Overriding selectors

Missing example

Templates

There's a lack of details, especially related to assets loading and operating on the variables from the FrontController. PrestaShop/PrestaShop#25668

Template hierarchy

The docs are here https://devdocs.prestashop.com/1.7/themes/reference/templates/templates-layouts/#specific-templates

But it's called "template hierarchy" in the WordPress world, and I'm sure some will look for this using this phrase.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant