Skip to content

Commit fd54995

Browse files
committed
Fix complete hook behaviour + run gulp task
1 parent e58b6c0 commit fd54995

File tree

6 files changed

+27
-23
lines changed

6 files changed

+27
-23
lines changed

components/prism-core.js

+11-10
Original file line numberDiff line numberDiff line change
@@ -172,25 +172,24 @@ var _ = _self.Prism = {
172172
parent.className = parent.className.replace(lang, '').replace(/\s+/g, ' ') + ' language-' + language;
173173
}
174174

175-
if (!grammar) {
176-
return;
177-
}
178-
179175
var code = element.textContent;
180176

181-
if(!code) {
182-
return;
183-
}
184-
185-
code = code.replace(/^(?:\r?\n|\r)/,'');
186-
187177
var env = {
188178
element: element,
189179
language: language,
190180
grammar: grammar,
191181
code: code
192182
};
193183

184+
if(code) {
185+
env.code = code.replace(/^(?:\r?\n|\r)/, '');
186+
}
187+
188+
if (!code || !grammar) {
189+
_.hooks.run('complete', env);
190+
return;
191+
}
192+
194193
_.hooks.run('before-highlight', env);
195194

196195
if (async && _self.Worker) {
@@ -205,6 +204,7 @@ var _ = _self.Prism = {
205204

206205
callback && callback.call(env.element);
207206
_.hooks.run('after-highlight', env);
207+
_.hooks.run('complete', env);
208208
};
209209

210210
worker.postMessage(JSON.stringify({
@@ -222,6 +222,7 @@ var _ = _self.Prism = {
222222
callback && callback.call(element);
223223

224224
_.hooks.run('after-highlight', env);
225+
_.hooks.run('complete', env);
225226
}
226227
},
227228

components/prism-core.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

plugins/line-highlight/prism-line-highlight.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

plugins/line-numbers/index.html

+6
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,12 @@ <h2>CSS</h2>
4343
<h2>HTML</h2>
4444
<p>Please note the <code>data-start="-5"</code> in the code below.</p>
4545
<pre class="line-numbers" data-src="plugins/line-numbers/index.html" data-start="-5"></pre>
46+
47+
<h2>Unknown languages</h2>
48+
<pre class="language-none line-numbers"><code>This raw text
49+
is not highlighted
50+
but it still has
51+
lines numbers</code></pre>
4652
</section>
4753

4854
<footer data-src="templates/footer.html" data-type="text/html"></footer>

plugins/line-numbers/prism-line-numbers.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

prism.js

+7-10
Original file line numberDiff line numberDiff line change
@@ -179,20 +179,18 @@ var _ = _self.Prism = {
179179

180180
var code = element.textContent;
181181

182-
if(!code) {
183-
return;
184-
}
185-
186-
code = code.replace(/^(?:\r?\n|\r)/,'');
187-
188182
var env = {
189183
element: element,
190184
language: language,
191185
grammar: grammar,
192186
code: code
193187
};
194188

195-
if (!grammar) {
189+
if(code) {
190+
env.code = code.replace(/^(?:\r?\n|\r)/, '');
191+
}
192+
193+
if (!code || !grammar) {
196194
_.hooks.run('complete', env);
197195
return;
198196
}
@@ -211,6 +209,7 @@ var _ = _self.Prism = {
211209

212210
callback && callback.call(env.element);
213211
_.hooks.run('after-highlight', env);
212+
_.hooks.run('complete', env);
214213
};
215214

216215
worker.postMessage(JSON.stringify({
@@ -228,10 +227,8 @@ var _ = _self.Prism = {
228227
callback && callback.call(element);
229228

230229
_.hooks.run('after-highlight', env);
230+
_.hooks.run('complete', env);
231231
}
232-
233-
_.hooks.run('complete', env);
234-
235232
},
236233

237234
highlight: function (text, grammar, language) {

0 commit comments

Comments
 (0)