Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Docstring improvement for ConvertToMultiChannelBasedOnBratsClasses #8225

Closed
mingxin-zheng opened this issue Nov 21, 2024 · 0 comments · Fixed by #8246
Closed

Docstring improvement for ConvertToMultiChannelBasedOnBratsClasses #8225

mingxin-zheng opened this issue Nov 21, 2024 · 0 comments · Fixed by #8246
Labels
Contribution wanted enhancement New feature or request good first issue Good for newcomers

Comments

@mingxin-zheng
Copy link
Contributor

Describe the bug

The docstring below was confusing to read for people who haven't worked on BRATS 18 before (e.g. me)

Convert labels to multi channels based on brats18 classes:

I would suggest to elaborate it as below:

Convert labels to multi channels based on brats18 classes, which include TC (Tumor core), WT (Whole tumor) and ET (Enhancing tumor) in order.
According to the [official page](https://www.med.upenn.edu/sbia/brats2018/data.html)
    label 1 is the necrotic and non-enhancing tumor core, which should be counted under TC and WT subregion
    label 2 is the peritumoral edema, which is counted only under WT subresion
    label 4 is the GD-enhancing tumor, which should be counted under ET, TC, WT subregions

Expected behavior
A clear and concise description of the function behavior and expected outputs

Additional context
Related issue: Project-MONAI/tutorials#1355
Related comment: Project-MONAI/VLM#55 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Contribution wanted enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants