Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Regression in bearings computations #4704

Closed
oxidase opened this issue Nov 25, 2017 · 2 comments
Closed

Regression in bearings computations #4704

oxidase opened this issue Nov 25, 2017 · 2 comments
Labels
Bug Report Guidance

Comments

@oxidase
Copy link
Contributor

oxidase commented Nov 25, 2017

An edge case for #4331 and #4443
http://map.project-osrm.org/?z=18&center=32.661272%2C-117.078831&loc=32.661173%2C-117.078284&loc=32.661358%2C-117.079378&hl=en&alt=0
screenshot from 2017-11-25 19-04-46

Fix #4443 uses the first edge for the base initial bearing that gives no guarantee of the correct ordering.
@oxidase
Copy link
Contributor Author

oxidase commented Nov 28, 2017

@karenzshea diff.txt is a patch to revert #4443 and fixes the issue, but breaks features/guidance/turn.feature:1357 again.

@miccolis miccolis assigned karenzshea and unassigned karenzshea Nov 28, 2017
@oxidase oxidase mentioned this issue Dec 7, 2017
Merged
10 tasks
@oxidase
Copy link
Contributor Author

oxidase commented Feb 2, 2018

Fixed in 5.15.1 release

@oxidase oxidase closed this as completed Feb 2, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Bug Report Guidance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oxidase @karenzshea