-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
5.27 Release? #6325
Comments
It effectively means configuring build with ENABLE_NODE_BINDINGS=ON on Windows and packaging resulting module on releases? |
Yes, hopefully we can just reuse the Node package/publish step
No, we can no longer publish to Docker Hub due to a change in the TOS (hence the missing version). We've switched to using Github Packages container registry (#6138), so it will publish here in the next release. That's something else that we will need to update in the docs. |
Btw I would also think about publishing Node module for Apple Silicon Macs. |
It's not possible yet with Github hosted runners: actions/runner-images#2187 |
AFAIR we can cross-compile for M1 on old Macs. I'll try to experiment with it at some day. |
Well, it is possible: #6360 Just need to clean it up and figure out how to properly build release package. |
Release candidate is out. Looks like all the new deployment infrastructure is working 🎉 |
Given the recent activity with a number of fixes/improvements hitting master, it might be worth making a new release.
Here are some additional changes that I think should also be included:
Migrate to modern TBB version #6300
Fix TBB in case of Conan + NodeJS build #6324
Get rid of Mason #6387
Update http.md #6150
Update docs to reflect recent build and dependency changes #6383
node-pre-gyp
has Windows support.Build Node bindings on Windows #6334
Configure cross-compilation for Apple Silicon #6360
Improvements to maneuver override processing #6215
osrm-extract assert triggering on guidance intersection handler #6218
Assertion makes osrm-extract fail #6373
Support snapping to multiple ways at an input location #5953
Fix snapping target locations to ways used in turn restrictions #6339
Support OSM traffic signal directions #6153
Any other suggestions/thoughts?
The text was updated successfully, but these errors were encountered: