Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Library/Test is Broken #5

Open
ireksawicki opened this issue Sep 13, 2017 · 2 comments
Open

Library/Test is Broken #5

ireksawicki opened this issue Sep 13, 2017 · 2 comments
Assignees

Comments

@ireksawicki
Copy link

Hi,

After recent commit the library running on PHP 7 is failing.

Class 'projectcleverweb\color\data\validate' not found

Here's the printscreen with the full trace:
http://prntscr.com/gkjjli

best,
I.

@ProjectCleverWeb
Copy link
Owner

ProjectCleverWeb commented Sep 13, 2017

The library is being refactored so it can support more complex operations. These new operations will allow you to edit colors based on how humans actually observe color. This will allow features such as emulating color blindness, more fluid gradients, better schemes, etc.

At the moment, half the unit tests are now broken or depreciated, and until the refactoring is done more and more tests will break. Unit testing fixes will come a few commits down the road after the refactor is complete. Until then please use the following code to revert to a more stable commit:

git reset --hard dfd287476deee32bc5200ab06988dc9db84ed4ed

That commit should be pretty stable. However, please keep in mind that this library is in its developmental phase. Despite how simple it appears, the mathematics and operations needed to manipulate colors in programming can be very complex, and there are often several official ways to do what is supposed to be the same thing.

I will update and close this issue and when the refactor is complete, so you can start using the latest development again.

Sorry for any convenience this has caused. I will fix it as soon as I am able to.

@ProjectCleverWeb ProjectCleverWeb changed the title color\data\validate is broken on the PHP 7 version Library/Test is Broken Sep 13, 2017
@ProjectCleverWeb ProjectCleverWeb self-assigned this Sep 13, 2017
@ireksawicki
Copy link
Author

Hi ProjectCleverWeb,

Thanks for the reply. I just wanted to report broken PHP 7 version - and it's not only about the tests, but the normal runtime too. :) All you have to do to reproduce it is just simple new projectcleverweb\color\main('#ffffff') on PHP7.

I've already forked this lib with reverted last commit yesterday but thanks for the advice.

I'm sure it was not easy to handle all the equations. Overall this library does a great job if it comes to color manipulations in the PHP - thank you for developing and sharing it!

Best,
I.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants