From e5013775871d47e330beb29b06dd5467488041b0 Mon Sep 17 00:00:00 2001
From: Icxolu <10486322+Icxolu@users.noreply.github.com>
Date: Fri, 12 Apr 2024 08:34:27 +0200
Subject: [PATCH] fix declarative-modules compile error (#4054)

* fix declarative-modules compile error

* add newsfragment
---
 newsfragments/4054.fixed.md        |  1 +
 pyo3-macros-backend/src/pyclass.rs |  2 +-
 tests/test_declarative_module.rs   | 11 +++++++++++
 3 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 newsfragments/4054.fixed.md

diff --git a/newsfragments/4054.fixed.md b/newsfragments/4054.fixed.md
new file mode 100644
index 00000000000..4b8da92ca4d
--- /dev/null
+++ b/newsfragments/4054.fixed.md
@@ -0,0 +1 @@
+Fixes a compile error when exporting a `#[pyclass]` living in a different Rust module using the declarative-module feature.
diff --git a/pyo3-macros-backend/src/pyclass.rs b/pyo3-macros-backend/src/pyclass.rs
index cf8d9aae801..aff23b879f5 100644
--- a/pyo3-macros-backend/src/pyclass.rs
+++ b/pyo3-macros-backend/src/pyclass.rs
@@ -1614,7 +1614,7 @@ impl<'a> PyClassImplsBuilder<'a> {
         quote! {
             impl #cls {
                 #[doc(hidden)]
-                const _PYO3_DEF: #pyo3_path::impl_::pymodule::AddClassToModule<Self> = #pyo3_path::impl_::pymodule::AddClassToModule::new();
+                pub const _PYO3_DEF: #pyo3_path::impl_::pymodule::AddClassToModule<Self> = #pyo3_path::impl_::pymodule::AddClassToModule::new();
             }
         }
     }
diff --git a/tests/test_declarative_module.rs b/tests/test_declarative_module.rs
index 5f8e2c9fa55..8e432c3ae58 100644
--- a/tests/test_declarative_module.rs
+++ b/tests/test_declarative_module.rs
@@ -9,6 +9,13 @@ use pyo3::types::PyBool;
 #[path = "../src/tests/common.rs"]
 mod common;
 
+mod some_module {
+    use pyo3::prelude::*;
+
+    #[pyclass]
+    pub struct SomePyClass;
+}
+
 #[pyclass]
 struct ValueClass {
     value: usize,
@@ -50,6 +57,10 @@ mod declarative_module {
     #[pymodule_export]
     use super::{declarative_module2, double, MyError, ValueClass as Value};
 
+    // test for #4036
+    #[pymodule_export]
+    use super::some_module::SomePyClass;
+
     #[pymodule]
     mod inner {
         use super::*;