Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Clippy borrow_deref_ref for &PyAny arguments #2555

Closed
stuhood opened this issue Aug 16, 2022 · 2 comments · Fixed by #2575
Closed

Clippy borrow_deref_ref for &PyAny arguments #2555

stuhood opened this issue Aug 16, 2022 · 2 comments · Fixed by #2575
Labels
bug

Comments

@stuhood
Copy link
Contributor

stuhood commented Aug 16, 2022 •
edited
Loading

Bug Description

For code like this:
https://github.com/pantsbuild/pants/blob/c69a70c3837e5fdecdae5d3a0475a5e6fdfcf20f/src/rust/engine/src/externs/mod.rs#L298

... clippy under Rust 1.63.0 renders an error like the following:

error: deref on an immutable reference
   --> src/externs/mod.rs:298:17
    |
298 |     input_arg0: &PyAny,
    |                 ^ help: if you would like to reborrow, try removing `&*`: `&`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

Steps to Reproduce

  1. Check out pantsbuild/pants@main...stuhood:pants:stuhood/bump-to-rust-1.63.0-clippy-error
  2. Run ./cargo clippy (note the ./, which refers to a wrapper script to set up env vars)

Your operating system and version

macOS 11.6.8

Your Python version (python --version)

Python 3.7

Your Rust version (rustc --version)

1.63.0

Your PyO3 version

0.16.5

How did you install python? Did you use a virtualenv?

pyenv

Additional Info

No response
@stuhood stuhood added the bug label Aug 16, 2022
stuhood added a commit to stuhood/pants that referenced this issue Aug 16, 2022
@stuhood
Work around PyO3/pyo3#2555 and remove stale allow.
db25569 
[ci skip-build-wheels]
@davidhewitt davidhewitt mentioned this issue Aug 16, 2022
Closed
@davidhewitt
Copy link
Member

Ungh, yes, sorry about this. It's actually already fixed on main and I'm seeking to release 0.17 ASAP which will resolve (just working on a couple of other fixes to resolve at the same time). See #2493

@tsh56 tsh56 mentioned this issue Aug 16, 2022
Merged
@stuhood
Copy link
Contributor Author

stuhood commented Aug 16, 2022

Got it: thanks a lot! The workaround (skipping this clippy lint) is not onerous, so don't rush on our account.

@matteosantama matteosantama mentioned this issue Aug 19, 2022
Closed
22 tasks
@tushushu tushushu mentioned this issue Aug 20, 2022
Open
@davidhewitt davidhewitt mentioned this issue Aug 21, 2022
Merged
@tsh56 tsh56 mentioned this issue Aug 21, 2022
Closed
@andygrove andygrove mentioned this issue Aug 22, 2022
Closed
thomaskrause added a commit to korpling/annatto that referenced this issue Jan 20, 2023
@thomaskrause
Update to pyo3 to fix clippy lint
a0b988b 
PyO3/pyo3#2555
vlaci added a commit to onekey-sec/unblob that referenced this issue Apr 25, 2023
@vlaci
rust: update PyO3 dependency
3b20c28 
It tripped[^1] on clippy lints on Rustc 1.63:

    error: deref on an immutable reference
     --> rust/src/lib.rs:7:30
      |
    7 | pub fn shannon_entropy(data: &[u8]) -> PyResult<f64> {
      |                              ^ help: if you would like to reborrow, try removing `&*`: `&`
      |
      = note: `-D clippy::borrow-deref-ref` implied by `-D warnings`
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

    error: could not compile `unblob-rust` due to previous error

[^1]: PyO3/pyo3#2555
vlaci added a commit to onekey-sec/unblob that referenced this issue Apr 25, 2023
@vlaci
rust: update PyO3 dependency
460869e 
It tripped[^1] on clippy lints on Rustc 1.63:

    error: deref on an immutable reference
     --> rust/src/lib.rs:7:30
      |
    7 | pub fn shannon_entropy(data: &[u8]) -> PyResult<f64> {
      |                              ^ help: if you would like to reborrow, try removing `&*`: `&`
      |
      = note: `-D clippy::borrow-deref-ref` implied by `-D warnings`
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

    error: could not compile `unblob-rust` due to previous error

[^1]: PyO3/pyo3#2555
vlaci added a commit to onekey-sec/unblob that referenced this issue Apr 25, 2023
@vlaci
rust: update PyO3 dependency
03bbb84 
It tripped[^1] on clippy lints on Rustc 1.63:

    error: deref on an immutable reference
     --> rust/src/lib.rs:7:30
      |
    7 | pub fn shannon_entropy(data: &[u8]) -> PyResult<f64> {
      |                              ^ help: if you would like to reborrow, try removing `&*`: `&`
      |
      = note: `-D clippy::borrow-deref-ref` implied by `-D warnings`
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

    error: could not compile `unblob-rust` due to previous error

[^1]: PyO3/pyo3#2555
vlaci added a commit to onekey-sec/unblob that referenced this issue Apr 25, 2023
@vlaci
rust: update PyO3 dependency
c64dec1 
It tripped[^1] on clippy lints on Rustc 1.63:

    error: deref on an immutable reference
     --> rust/src/lib.rs:7:30
      |
    7 | pub fn shannon_entropy(data: &[u8]) -> PyResult<f64> {
      |                              ^ help: if you would like to reborrow, try removing `&*`: `&`
      |
      = note: `-D clippy::borrow-deref-ref` implied by `-D warnings`
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

    error: could not compile `unblob-rust` due to previous error

[^1]: PyO3/pyo3#2555
vlaci added a commit to onekey-sec/unblob that referenced this issue Apr 25, 2023
@vlaci
rust: update PyO3 dependency
b39f46f 
It tripped[^1] on clippy lints on Rustc 1.63:

    error: deref on an immutable reference
     --> rust/src/lib.rs:7:30
      |
    7 | pub fn shannon_entropy(data: &[u8]) -> PyResult<f64> {
      |                              ^ help: if you would like to reborrow, try removing `&*`: `&`
      |
      = note: `-D clippy::borrow-deref-ref` implied by `-D warnings`
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

    error: could not compile `unblob-rust` due to previous error

[^1]: PyO3/pyo3#2555
vlaci added a commit to onekey-sec/unblob that referenced this issue Apr 25, 2023
@vlaci
rust: update PyO3 dependency
84946b0 
It tripped[^1] on clippy lints on Rustc 1.63:

    error: deref on an immutable reference
     --> rust/src/lib.rs:7:30
      |
    7 | pub fn shannon_entropy(data: &[u8]) -> PyResult<f64> {
      |                              ^ help: if you would like to reborrow, try removing `&*`: `&`
      |
      = note: `-D clippy::borrow-deref-ref` implied by `-D warnings`
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

    error: could not compile `unblob-rust` due to previous error

[^1]: PyO3/pyo3#2555
vlaci added a commit to onekey-sec/unblob that referenced this issue Apr 25, 2023
@vlaci
rust: update PyO3 dependency
e4068d9 
It tripped[^1] on clippy lints on Rustc 1.63:

    error: deref on an immutable reference
     --> rust/src/lib.rs:7:30
      |
    7 | pub fn shannon_entropy(data: &[u8]) -> PyResult<f64> {
      |                              ^ help: if you would like to reborrow, try removing `&*`: `&`
      |
      = note: `-D clippy::borrow-deref-ref` implied by `-D warnings`
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

    error: could not compile `unblob-rust` due to previous error

[^1]: PyO3/pyo3#2555
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release: 0.17.0 PyO3/pyo3
2 participants
@stuhood @davidhewitt