python: add version() to get running version #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PyPy failure is upstream bug in |
|
Thanks for the review, I pushed some changes to address. Also I renamed this API to |
davidhewitt
force-pushed
the
py-version
branch
from
44727d2 to
bd3c4ab
Compare
kngwyu
reviewed
Dec 19, 2020
davidhewitt
force-pushed
the
py-version
branch
from
bd3c4ab to
71539b9
Compare
|
Thanks, simplified |
davidhewitt
force-pushed
the
py-version
branch
from
71539b9 to
f57ca1c
Compare
alex
reviewed
Dec 19, 2020
Closed
davidhewitt
force-pushed
the
py-version
branch
from
f57ca1c to
722814c
Compare
alex
reviewed
Dec 19, 2020
davidhewitt
force-pushed
the
py-version
branch
from
722814c to
2616d3d
Compare
alex
approved these changes
Dec 19, 2020
|
Thanks! |
kngwyu
approved these changes
Dec 20, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new API
Python::version()which is a safe convenience wrapper aroundPy_GetVersion().Now that we offer abi3 wheels which may need to support multiple different Python versions, such an API will come in helpful. We saw this already in #1320.