pymodule: accept #[pyo3(name = "...")] option
#1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
pymodule-name
branch
from
16f848a to
857987a
Compare
davidhewitt
force-pushed
the
pymodule-name
branch
2 times, most recently
from
4beb9bc to
56da6ef
Compare
davidhewitt
force-pushed
the
pymodule-name
branch
from
56da6ef to
18e0aa1
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1601
This PR makes
#[pymodule]accept the#[pyo3(name = "...")]attribute, and deprecates the previous#[pymodule(name)]way to set the name.