Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

PyList: fix segfault on get_item with negative indices #1668

Merged
merged 2 commits into from
Jun 6, 2021
Merged

PyList: fix segfault on get_item with negative indices #1668

merged 2 commits into from
Jun 6, 2021

Conversation

birkenfeld
Copy link
Member

See #1667.

davidhewitt
davidhewitt approved these changes Jun 6, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying up the tests at the same time.

I would think this is a user-facing crash worthy of a "Fixed" CHANGELOG entry?

@birkenfeld
Copy link
Member Author

Sure. Looks like I also unintentionally relied on IntoIter for arrays :)

@davidhewitt
Copy link
Member

Benchmark looks completely flaky so don't worry about that.

@birkenfeld birkenfeld merged commit f9a3da3 into main Jun 6, 2021
@birkenfeld birkenfeld deleted the pylist_fix branch June 6, 2021 08:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birkenfeld @davidhewitt