tests: switch to python_with_gil #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
approved these changes
Aug 12, 2021
Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
davidhewitt
approved these changes
Aug 13, 2021
There was a problem hiding this comment.
I think that the PyPy failures were independently fixed by #1787 (which I just merged), so I'm going to merge this now and worry about CI if stuff still breaks 😅
Thanks again for this tidy-up!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces most uses of
acquire_gilwithwith_gil.This is only in /src, not in /tests (yet)