Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix the signature of _PyLong_NumBits #2161

Merged
merged 3 commits into from
Feb 13, 2022
Merged

Fix the signature of _PyLong_NumBits #2161

merged 3 commits into from
Feb 13, 2022

Conversation

cmpute
Copy link
Contributor

@cmpute cmpute commented Feb 12, 2022

This commit is a simple fix of the signature of _PyLong_NumBits. It's correct C signature in longobject.h is

PyAPI_FUNC(size_t) _PyLong_NumBits(PyObject *v);

davidhewitt
davidhewitt reviewed Feb 12, 2022
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one quick thought...

@davidhewitt
Copy link
Member

(Also please add a CHANGELOG entry in the "Fixed" section)

@cmpute
Copy link
Contributor Author

cmpute commented Feb 12, 2022

Thanks for the suggestion! I updated the branch

@davidhewitt
Copy link
Member

Thanks! Afraid you might need to rebase; there's a merge conflict...

cmpute and others added 3 commits February 12, 2022 13:27
@cmpute
Fix the signature of _PyLong_NumBits
d99a001
@cmpute @davidhewitt
Update src/conversions/num_bigint.rs
9a775c4 
Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
@cmpute
Update CHANGELOG.md
de502f0
@cmpute
Copy link
Contributor Author

cmpute commented Feb 12, 2022

Should be ok now

@davidhewitt davidhewitt merged commit fd57a5e into PyO3:main Feb 13, 2022
@davidhewitt
Copy link
Member

Perfect, thanks again!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidhewitt davidhewitt davidhewitt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmpute @davidhewitt