refactor: move std conversions into common module #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
std-conversions
branch
from
d661888 to
5f74d9f
Compare
davidhewitt
force-pushed
the
std-conversions
branch
from
5f74d9f to
ec89bfe
Compare
davidhewitt
force-pushed
the
std-conversions
branch
from
ec89bfe to
ec8ae51
Compare
davidhewitt
force-pushed
the
std-conversions
branch
from
ec8ae51 to
fb34ed1
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a thought born out of #2650, to move conversions for all
stdtypes into a single point in the code so that it's easier to keep track of them.