Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Disable PyModule::filename on PyPy #2715

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Disable PyModule::filename on PyPy #2715

merged 1 commit into from
Nov 1, 2022

Conversation

messense
Copy link
Member

@messense messense force-pushed the fix-pymodule-filename-on-pypy branch from 9e2cf4d to 736e975 Compare October 31, 2022 07:46
adamreichold
adamreichold approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good candidate for inclusion into 0.17.3.

@messense
Copy link
Member Author

messense commented Nov 1, 2022

Merging, I've confirmed that this patch fixes the test failure with PyPy on macOS: https://github.com/PyO3/maturin/actions/runs/3366045809/jobs/5582152498

@messense messense merged commit 24dabc5 into PyO3:main Nov 1, 2022
@messense messense deleted the fix-pymodule-filename-on-pypy branch November 1, 2022 02:01
@messense messense mentioned this pull request Nov 1, 2022
Merged
@wshanks wshanks mentioned this pull request Feb 16, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@adamreichold adamreichold adamreichold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@messense @adamreichold