allow **kwargs to take arguments which conflict with positional-only parameters
#2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
positional-only-kwarg
branch
from
e63be0a to
f2cea0f
Compare
adamreichold
reviewed
Dec 9, 2022
davidhewitt
force-pushed
the
positional-only-kwarg
branch
from
f2cea0f to
e3bfc45
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 14, 2022
2800: allow `**kwargs` to take arguments which conflict with positional-only parameters r=davidhewitt a=davidhewitt Closes #2799 I did a little bit of refactoring at the same time, sorry! The bit which changes behaviour is that in the now-factored-out `handle_kwargs` method, if the keyword argument name is found in the positional-only range then the varkeywords handler is now given a chance to accept it. (Lines 387-390 in new `extract_argument.rs`.) Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
|
Build failed: |
davidhewitt
force-pushed
the
positional-only-kwarg
branch
from
e3bfc45 to
e8e02f0
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 15, 2022
2800: allow `**kwargs` to take arguments which conflict with positional-only parameters r=davidhewitt a=davidhewitt Closes #2799 I did a little bit of refactoring at the same time, sorry! The bit which changes behaviour is that in the now-factored-out `handle_kwargs` method, if the keyword argument name is found in the positional-only range then the varkeywords handler is now given a chance to accept it. (Lines 387-390 in new `extract_argument.rs`.) Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
|
Build failed: |
davidhewitt
force-pushed
the
positional-only-kwarg
branch
from
e8e02f0 to
33871b7
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 17, 2022
2709: ci: add Python 3.12-dev jobs r=davidhewitt a=davidhewitt Separately to #2708, time to start testing 3.12 alphas on CI. I imagine this might also take a while for the packages to come available. 2800: allow `**kwargs` to take arguments which conflict with positional-only parameters r=davidhewitt a=davidhewitt Closes #2799 I did a little bit of refactoring at the same time, sorry! The bit which changes behaviour is that in the now-factored-out `handle_kwargs` method, if the keyword argument name is found in the positional-only range then the varkeywords handler is now given a chance to accept it. (Lines 387-390 in new `extract_argument.rs`.) 2811: adjust vectorcall symbols for pypy r=davidhewitt a=davidhewitt Closes #2738 Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Dec 17, 2022
2800: allow `**kwargs` to take arguments which conflict with positional-only parameters r=davidhewitt a=davidhewitt Closes #2799 I did a little bit of refactoring at the same time, sorry! The bit which changes behaviour is that in the now-factored-out `handle_kwargs` method, if the keyword argument name is found in the positional-only range then the varkeywords handler is now given a chance to accept it. (Lines 387-390 in new `extract_argument.rs`.) 2811: adjust vectorcall symbols for pypy r=davidhewitt a=davidhewitt Closes #2738 Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
|
Build failed (retrying...): |
|
Build succeeded: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2799
I did a little bit of refactoring at the same time, sorry! The bit which changes behaviour is that in the now-factored-out
handle_kwargsmethod, if the keyword argument name is found in the positional-only range then the varkeywords handler is now given a chance to accept it. (Lines 387-390 in newextract_argument.rs.)