Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Define _PyDict_Contains_KnownHash() FFI for CPython 3.10 or later #3088

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Define _PyDict_Contains_KnownHash() FFI for CPython 3.10 or later #3088

merged 1 commit into from
Apr 10, 2023

Conversation

ijl
Copy link
Contributor

@ijl ijl commented Apr 7, 2023

No description provided.

@ijl
Copy link
Contributor Author

ijl commented Apr 7, 2023

https://github.com/python/cpython/blob/1e703a473343ed198c9a06a876b25d7d69d4bbd0/Include/cpython/dictobject.h#L61

https://github.com/python/cpython/blob/8d015fa000db5775d477cd04dc574ba13721e278/Objects/dictobject.c#L3696-L3708

messense
messense approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Apr 10, 2023
@bors @ijl
Merge #3088
042bcc7 
3088: Define _PyDict_Contains_KnownHash() FFI for CPython 3.10 or later r=messense a=ijl



Co-authored-by: ijl <ijl@mailbox.org>
@bors
Copy link
Contributor

bors bot commented Apr 10, 2023

Build failed:

@adamreichold
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request Apr 10, 2023
@bors @ijl
Merge #3088
08e0196 
3088: Define _PyDict_Contains_KnownHash() FFI for CPython 3.10 or later r=messense a=ijl



Co-authored-by: ijl <ijl@mailbox.org>
@bors
Copy link
Contributor

bors bot commented Apr 10, 2023

Build failed:

@adamreichold
Copy link
Member

I think the failure of the careful CI job is due it using nightly Rust and some new warnings on main unrelated to the changes here. Will open a separate PR trying to fix this...

@adamreichold
Copy link
Member

Retry after main was fixed.

bors retry

@bors
Copy link
Contributor

bors bot commented Apr 10, 2023

Build succeeded:

  • conclusion

@bors bors bot merged commit 275e661 into PyO3:main Apr 10, 2023
@ijl ijl deleted the pydict-contains-known-hash branch April 11, 2023 14:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@messense messense messense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijl @adamreichold @messense