Fix memory leak in ArrayList #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kngwyu
added a commit
to kngwyu/pyo3
that referenced
this pull request
Dec 27, 2018
|
I also pushed this commit to https://github.com/PyO3/pyo3/tree/0_5_backports. |
|
Thank you for fixing and backporting this! Unfortunately releasing is blocked on rust-lang/rust#57176, but I'll publish once that is fixed. |
|
I've published 0.5.3 :) |
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make algorithm clear, I designed
pythonrun::array_list::ArrayListto always have minimum capacity to hold pointers.But I found a bug. In current implementation, when arraylist's length becomes 0 from 1, excess capacity remains and causes memory leak.
It's my mistake, sorry 😓
@konstin
This is a serious bug so could you please release 0.5.3 with this PR?