Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement DoubleEndedIterator for PyTupleIterator #3366

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Implement DoubleEndedIterator for PyTupleIterator #3366

merged 2 commits into from
Aug 8, 2023

Conversation

adamreichold
Copy link
Member

@adamreichold adamreichold commented Aug 3, 2023 •
edited
Loading

No description provided.

davidhewitt
davidhewitt reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I agree with the functionality! I guess the same for list is more tricky due to possible mutation during iteration? (Though we guard against that IIRC.)

Just a few review comments...

@adamreichold
Copy link
Member Author

Thanks, I agree with the functionality! I guess the same for list is more tricky due to possible mutation during iteration? (Though we guard against that IIRC.)

I added the impl for PyListIterator as a separate commit by caching the length of the list while continuing to validate it before access.

davidhewitt
davidhewitt approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Looks good to me 👍

@adamreichold adamreichold added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit 28b8623 Aug 8, 2023
@adamreichold adamreichold deleted the tuple-rev branch August 8, 2023 04:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamreichold @davidhewitt