Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Avoid generating functions that are only ever const evaluated with declarative modules #4297

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Avoid generating functions that are only ever const evaluated with declarative modules #4297

merged 1 commit into from
Jul 1, 2024

Conversation

alex
Copy link
Contributor

@alex alex commented Jun 27, 2024

Refs #4286

@alex alex added the CI-skip-changelog Skip checking changelog entry label Jun 27, 2024
davidhewitt
davidhewitt approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's add a newsfragment (maybe either changed or fixed) and merge this 👍

@alex
Copy link
Contributor Author

alex commented Jul 1, 2024 via email

@davidhewitt
Copy link
Member

Yes exactly - maybe "fixed uncoverable region in declarative modules"?

@alex alex removed the CI-skip-changelog Skip checking changelog entry label Jul 1, 2024
@alex alex enabled auto-merge July 1, 2024 21:34
@alex alex added this pull request to the merge queue Jul 1, 2024
Merged via the queue into PyO3:main with commit f3603a0 Jul 1, 2024
42 checks passed
@alex alex deleted the const-eval branch July 1, 2024 22:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex @davidhewitt